Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 26212 #26213

Closed
wants to merge 2 commits into from
Closed

Conversation

rickymemphis
Copy link

Hi Everyone,

This PR is a tentative to fix this issue
can you please have a look and let me know what you thing?

Best,
Riccardo

@hz-devops-test hz-devops-test added the Source: Community PR or issue was opened by a community user label Jan 12, 2024
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Riccardo Nieto seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@devOpsHazelcast
Copy link
Collaborator

Internal PR hazelcast/hazelcast-mono#403
Internal message only. Nothing to see here, move along

@rickymemphis
Copy link
Author

Quick update from my side:

  • My Github account did not have the email set
  • It seems to me that I have signed the CLA even if it still looks pending
Screenshot 2024-01-17 at 09 20 06

@lukasblu
Copy link
Contributor

run-lab-run

@devOpsHazelcast
Copy link
Collaborator

This pull request has been closed because it was already closed as https://github.com/hazelcast/hazelcast-mono/pull/403

@lukasblu
Copy link
Contributor

Hi @vbekiaris ,

could you also have a look at this small PR? @ahmetmircik already approved it and it would be nice to finish this story.

Thx,
Lukas

@devOpsHazelcast devOpsHazelcast added this to the 5.5.0 milestone May 21, 2024
@vbekiaris vbekiaris closed this May 21, 2024
devOpsHazelcast pushed a commit that referenced this pull request May 21, 2024
This PR fixes #26212

Imported changes:

  - 38b7ad5 added unit tests
- 3a4d8a5 update stats when existing
record is removed

Closes #26213

Co-authored-by: Riccardo Nieto <riccardo.nieto@appway.com>
GitOrigin-RevId: 500592c3f618cb669a884b2263a640c5566459b3
@vbekiaris
Copy link
Contributor

thanks @rickymemphis for the fix (and @lukasblu for the nudge)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source: Community PR or issue was opened by a community user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants