New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decode_ignored_any
#4
Conversation
closes #2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Drew! Do you think you could bring some of the parsing improvements into the parse_*
methods? For example parse_number
could call parse_decimal
, parse_exponent
, etc. This could be in a separate PR if you prefer.
@haydnv thanks for the review -
|
It would be great if you can add the expected failure tests in this PR |
okay! @haydnv sorry for the delay. i've added a bunch more test cases, and ran |
Thanks Drew, great work! |
this beefs up the implementation for ignoring values, mostly lifted from serde's implementation. added a bunch of tests, which pass and these changes also fix the broken tests that led me to these changes in another repository of mine that's making use of this library.
peek_or_null
,eat_char
, etc.)