Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vendor class to be used without FIFO. #2450

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

HiFiPhile
Copy link
Collaborator

@HiFiPhile HiFiPhile commented Feb 1, 2024

Describe the PR
Currently vendor class manage data the same way as CDC class.

Many protocols using buck transfer are based on packets but not data stream like CDC.
In these cases a FIFO is not needed which adds overhead, also putting all packets in FIFO adds extra difficulty to separate them since length of each packet is lost.

Additional context
I'm trying to make a CMSIS-DAP dongle.

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use existing CFG_TUD_VENDOR_RX_BUFSIZE when not defined or defined to 0 mean no buffered. https://github.com/hathach/tinyusb/blob/master/examples/device/webusb_serial/src/tusb_config.h#L104-L105

I am off for TET holidays for a couple of weeks. Will try to review afterwards, thank you for your patient.

@HiFiPhile
Copy link
Collaborator Author

we can use existing CFG_TUD_VENDOR_RX_BUFSIZE when not defined or defined to 0 mean no buffered.

That's true.

Me too I was back to China for holidays:)

@hathach
Copy link
Owner

hathach commented Feb 6, 2024

we can use existing CFG_TUD_VENDOR_RX_BUFSIZE when not defined or defined to 0 mean no buffered.

That's true.

Me too I was back to China for holidays:)

Have a great year of 🐉

@HiFiPhile
Copy link
Collaborator Author

we can use existing CFG_TUD_VENDOR_RX_BUFSIZE when not defined or defined to 0 mean no buffered.

@hathach Done

@HiFiPhile
Copy link
Collaborator Author

Additional context
I'm trying to make a CMSIS-DAP dongle.

@kkitayam Didn't see that you've already done it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants