bugfix(ch32-hs-dcd): fix ch32 DATAx managment and long packet transmit #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krasutski
force-pushed
the
bugfix/ch32-hs-dcd
branch
3 times, most recently
from
9d9a427
to
6a13b0a
Compare
Krasutski
force-pushed
the
bugfix/ch32-hs-dcd
branch
from
6a13b0a
to
c6e3fc0
Compare
Krasutski
force-pushed
the
bugfix/ch32-hs-dcd
branch
from
7b3fb59
to
ddf329f
Compare
|
This MR seems to resolve issues I was having getting writes to work reliably with the MSC device class. 👍 |
|
My problem in #2377 is also fixed with this MR! |
|
@hathach Could you check and merge PR? |
hathach
reviewed
Feb 6, 2024
|
@hathach how can I help to complete this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old implementations have some issues:
Fixed this issue #1891 also other examples now work stable
UPD:
Pushed one more commit, fixed iso transfers, probably this issue fixed: #2325