da146xx usb complience #1146
da146xx usb complience #1146
Conversation
Normal TX handler for IN non-0 endpoints is called during outgoing transfer or just after it was finished. It may need to fill TX fifo with same data if TX_DONE is present but ACK_STAT is not. It may need to fill more data when called during transfer. But it may also be called when STALL was sent. In this case TX_DONE is set ACK_STAT is not, just like for packets that were sent but no ACK was received. Code was trying to send something again. There was nothing to send so empty ZLP was scheduled for stalled endpoint. This ZLP was later send to host where valid response was required. This change checks if notification was for STALL endpoint and does not try to fill TX FIFO in that case.
USB3CV tool verifies MSC device by sending too short or too long packets. In case of too long packets (msc_device requested 31 bytes but incoming data had 32 bytes) extra byte(s) were left in FIFO resulting in some data mismatch later on. Now if more data is received in packet that expected extra bytes are just dropped.
|
Here are test results: For reference behavior I used STM32F407 board that was working as test expected. |
There was a problem hiding this comment.
Here are test results: This time Chapter 9 tests were run on HID with remote wake up tested. USB3CV.zip
Superb !! great effort to get DA146xx fully passed the USBCV.
For reference behavior I used STM32F407 board that was working as test expected.
For some reason when MSC tests were run on PCA10056 it was failing almost all tests I'm not sure if this was just my board or some regression snicked in.I used Preview DK which does not have final chip version. With DK all works well.
yeah, the PDK USB is unusable.
Describe the PR
This resolves to problems that prevent USB3CV compliance test to pass for DA146xx devices.
wrong response after endpoint was un-stalled.
left for next read. It resulted in compliance test failure for MSC device.
Now TX FIFO is not filled for stalled endpoint and extra (unexpected) bytes from RX FIFO are dropped.
Additional context
Follow up on #1101 and #1059