Add pure functional dropout #456
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscholak
reviewed
Sep 13, 2020
| -> Maybe Generator -- ^ generator | ||
| -> Tensor -- ^ input | ||
| -> (Tensor,Generator) -- ^ output | ||
| dropout p Nothing input = cast3 ATen.dropout_tdb input p False |
There was a problem hiding this comment.
Hi @junjihashimoto, this looks great, thank you for working on this.
This line here is odd, though. I don't understand how this can return a Generator when Nothing is passed into it. Isn't ATen.dropout_tdb the one that returns IO Tensor?
There was a problem hiding this comment.
Thank you for your pointing it out. If the input generator is Nothing, the output generator should also return Nothing or just a Tensor(not the Tuple).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides pure functional dropout.
dropout implementation is here.
When training, it uses _fused_dropout. _fused_dropout can use local generater.
https://github.com/pytorch/pytorch/blob/1.6/aten/src/ATen/native/Dropout.cpp
https://github.com/pytorch/pytorch/blob/1.6/aten/src/ATen/native/native_functions.yaml#L167