Warnings 9.4.5 #372
Merged
Warnings 9.4.5 #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am fine with this impact as we do not have widespread users to be affected. @facundominguez what are your thoughts? |
|
Looks good to me. Maybe it is worth checking if it affects manipulating |
|
One can definitely still manipulate |
facundominguez
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes a bunch of compilation warnings. The only nontrivial change is that
Serializableis now a type synonym instead of a separate class. This could potentially affect users who try to useSerializablein a partially applied form -- they would have to define their own class.