Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usePrivateIP for cloudsql postgresql instances #26828

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KyriosGN0
Copy link

@KyriosGN0 KyriosGN0 commented May 4, 2024

🛠️ Description

add the ability to speificy if the cloudsql postgresql instance has private ip we should use
right now we fail if the instance has only public ip

Closes #26827

Signed-off-by: aviv guiser <avivguiser@gmail.com>
Signed-off-by: aviv guiser <avivguiser@gmail.com>
@KyriosGN0 KyriosGN0 requested a review from a team as a code owner May 4, 2024 18:22
@hsimon-hashicorp hsimon-hashicorp added ecosystem database/gcp/cloudsql bug Used to indicate a potential bug labels May 7, 2024
@sviatlo
Copy link

sviatlo commented May 11, 2024

Hello @hsimon-hashicorp!
We've been dreaming of using Vault to authenticate with gcp sql. Is there any chance you can help to facilitate/expedite the review of this PR?
Thank you in advance!

@hsimon-hashicorp
Copy link
Contributor

Hello @hsimon-hashicorp! We've been dreaming of using Vault to authenticate with gcp sql. Is there any chance you can help to facilitate/expedite the review of this PR? Thank you in advance!

Hi there! Thank you for the ping (genuinely, I appreciate it!) as well as your enthusiasm for this PR. I will check with our engineering and product management teams to see if we can get some eyes on this. I can't make any guarantees about timelines, but this does give me more data about community sentiment which is very valuable to me. Thanks again! ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow private ip for cloudsql auth integration
3 participants