Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envs for VAULT_ADDR and VAULT_TOKEN should not be reqd #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shezaan
Copy link

@shezaan shezaan commented Aug 27, 2021

Once the injector is configured with an external vault address and kubernetes and the kubernetes auth backend is correctly configured with the role there should be no need to expose VAULT_ADDR and VAULT_TOKEN as part of the env as well as commit to git (if necessary). It would kill the whole point of the injector.

Also please correct your learn guide where it says

Display the pod with annotations pod-devwebapp-with-annotations.yaml

Followed by cat patch-02-inject-secrets.yml
The filename following the cat command is incorrect and should be pod-devwebapp-with-annotations.yaml

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants