Update configure_disks.rb #13346
Open
Update configure_disks.rb #13346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed configure_disks.rb in hyper-v capabilities provider to allow creation and removal of additional disks,
|
|
|
Added double splat to created_disk and attach_disk invocations to explicitly allow the implicit conversions disabled in Ruby 3.x. |
|
Dear mantainers, can we proceed with workflows approval? can you enable me to run workflows needed for final review? Best regards. Camillo |
|
Camillo - appreciate you sharing this fix... hopefully it gets reviewed and merged soon. |
|
Dear Paul - Thank you. Have you any news about any incoming review? |
|
No. I'm not a maintainer, just a user.
…On Tue, Apr 16, 2024, 06:45 Camillo Toselli ***@***.***> wrote:
Dear Paul - Thank you. Have you any news about any incoming review?
—
Reply to this email directly, view it on GitHub
<#13346 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU3TQYUUPOCWMPG7TVFYJSLY5UTNXAVCNFSM6AAAAABCQ674V2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZGEZTCOBVHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed configure_disks.rb in hyper-v capabilities provider to allow creation and removal of additional disks,