Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_bedrock_foundation_models(test): fix semgrep finding #37467

Merged
merged 1 commit into from
May 13, 2024
Merged

d/aws_bedrock_foundation_models(test): fix semgrep finding #37467

merged 1 commit into from
May 13, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented May 13, 2024 •
edited

Description

Fixes a failing semgrep finding on main.

https://github.com/hashicorp/terraform-provider-aws/actions/runs/9062758632/job/24897300698

Relations

Relates #37306

Output from Acceptance Testing

% make testacc PKG=bedrock TESTS=TestAccBedrockFoundationModelsDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrockFoundationModelsDataSource_'  -timeout 360m

--- PASS: TestAccBedrockFoundationModelsDataSource_byCustomizationType (9.86s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byInferenceType (10.17s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byProvider (10.20s)
--- PASS: TestAccBedrockFoundationModelsDataSource_basic (10.24s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byOutputModality (10.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrock    15.375s

@jar-b
d/aws_bedrock_foundation_models(test): fix semgrep finding
f47da6b 
```console
% make testacc PKG=bedrock TESTS=TestAccBedrockFoundationModelsDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrockFoundationModelsDataSource_'  -timeout 360m

--- PASS: TestAccBedrockFoundationModelsDataSource_byCustomizationType (9.86s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byInferenceType (10.17s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byProvider (10.20s)
--- PASS: TestAccBedrockFoundationModelsDataSource_basic (10.24s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byOutputModality (10.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrock    15.375s
```
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/bedrock Issues and PRs that pertain to the bedrock service. labels May 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 13, 2024
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label May 13, 2024
@jar-b jar-b merged commit c3f1622 into main May 13, 2024
77 checks passed
@jar-b jar-b deleted the td-semgrep branch May 13, 2024 12:58
@github-actions github-actions bot added this to the v5.50.0 milestone May 13, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
service/bedrock Issues and PRs that pertain to the bedrock service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.50.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jar-b