Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use single-label runner for custom-linux-xl #3623

Merged
merged 1 commit into from
May 28, 2024

Conversation

dlaguerta
Copy link
Contributor

@dlaguerta dlaguerta commented May 16, 2024

Description

To align with Github’s removal of custom labels on larger runners, this PR is updating the labels defined in your Github Action jobs. Moving forward, only one label (the name of GH runner type) will be needed to ensure an appropriate runner is used for your GHA job.

Please review for accuracy and merge before May 27, 2024. Thank you!

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@dlaguerta dlaguerta requested a review from a team as a code owner May 16, 2024 19:38
@dlaguerta dlaguerta requested review from mutahhir and DanielMSchmidt and removed request for a team May 16, 2024 19:38
@dlaguerta dlaguerta changed the title Use single-label runner for custom-linux-xl chore: Use single-label runner for custom-linux-xl May 16, 2024
@ansgarm ansgarm merged commit 0d01cf3 into main May 28, 2024
430 checks passed
@ansgarm ansgarm deleted the PSS-139-single-runner-labels branch May 28, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants