Upgrade github.com/armon/go-metrics to github.com/hashicorp/go-metrics #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also requires bumping the module version to v2. Technically there is no API incompatibility but its a breaking change due to important side effects not happening correctly. That side effect is that programs using armon/go-metrics and having Raft emit metrics to the global metrics handler would no longer see metrics unless they also upgrade to hashicorp/go-metrics. This is due to Go treating the armon/go-metrics and hashicorp/go-metrics as distinct modules. If both are present in the program than each will have a separate global metrics handler causing only partial metrics to be seen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also requires bumping the module version to v2. Technically there is no API incompatibility but its a breaking change due to important side effects not happening correctly. That side effect is that programs using armon/go-metrics and having Raft emit metrics to the global metrics handler would no longer see metrics unless they also upgrade to hashicorp/go-metrics.
This is due to Go treating the armon/go-metrics and hashicorp/go-metrics as distinct modules. If both are present in the program than each will have a separate global metrics handler causing only partial metrics to be seen.
TODO: