Fix ArgoCD hooks annotation location #3989
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
ArgoCD hooks to be set to Job annotations and not at Job template spec level -> https://argo-cd.readthedocs.io/en/stable/user-guide/resource_hooks/#usage
If set at current Job template spec level when Job is finished ArgoCD detects back again diff entering into a loop, if ArgoCD AutoSync is enabled this will be a loop of init jobs running forever.
fix: #3831
How I've tested this PR
How I expect reviewers to test this PR
Checklist