Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of NET-9178-Consul-api-gateway-not-starting-after-restart into release/1.2.x #3987

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #3978 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR

  • If role already exists, don't error out of connect inject.

How I've tested this PR

  • Local build, create api gateway, delete connect inject. Before this change, connect inject would crash with 'role already exists', after this change, connect inject ignores that the role already exists and continues to operate as expected.

How I expect reviewers to test this PR

  • Local Build, CI passes

Checklist


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-9178-Consul-api-gateway-not-starting-after-restart/jointly-composed-cod branch from 2caffc4 to 93c4e6f Compare May 9, 2024 19:30
sarahalsmiller and others added 4 commits May 21, 2024 13:28
…y-not-starting-after-restart/jointly-composed-cod
…y-not-starting-after-restart/jointly-composed-cod
…y-not-starting-after-restart/jointly-composed-cod
@hc-github-team-consul-core hc-github-team-consul-core merged commit c9ebcd4 into release/1.2.x May 22, 2024
23 of 47 checks passed
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/NET-9178-Consul-api-gateway-not-starting-after-restart/jointly-composed-cod branch May 22, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants