ArgoCD hook annotations on the server-acl-init-job do not work

[0011blindmice]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

While installing the Consul chart via ArgoCD, there are continuous Out-of-Sync warnings due to the init job being cleaned by a separate hook, leaving ArgoCD under the assumption that there is drift from the intended manifest.

There is currently a values entry to add ArgoCD's specific annotations for cleaning up hooks post-success, but they are being applied at the pod level of the spec.

i.e.

consul-k8s/charts/consul/templates/server-acl-init-job.yaml

Line 50 in caee250

{{- if .Values.global.acls.annotations }}

It is my understanding this block of the template should actually be in the root .metadata.annotations of the job.

Reproduction Steps

1. When running helm install with the following values.yml:

global:
  argocd:
    enabled: true

Logs

Expected behavior

Ideally, the hook annotation would be at the Job's top level, as that is the resource that appears to be getting destroyed and triggering the sync disparity.

Environment details

Consul version: 1.4.0
ArgoCD: 2.10.1