chore: Update to use Node20 version of Actions #4787
Conversation
moduli
added
pr/no-milestone
moduli
force-pushed
the
moduli-actions-node20
branch
from
7149376
to
594dcc8
Compare
moduli
force-pushed
the
moduli-actions-node20
branch
from
594dcc8
to
d76013f
Compare
| - uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | ||
| with: | ||
| name: ${{ env.PKG_NAME }}_${{ needs.set-product-version.outputs.product-version }}_${{ matrix.goos }}_${{ matrix.goarch }}.zip | ||
| path: out/${{ env.PKG_NAME }}_${{ needs.set-product-version.outputs.product-version }}_${{ matrix.goos }}_${{ matrix.goarch }}.zip |
There was a problem hiding this comment.
upload-artifact-v4 adds a check where you can't upload something if it already exists. It looks like actions-go-build already has an upload step, so we're removing the step here.
| @@ -27,7 +27,7 @@ jobs: | |||
| with: | |||
| repository: "grafana/grafana-github-actions" | |||
| path: ./actions | |||
| ref: be89ad434792280ebaa4d982ac72ba548b6f7095 | |||
| ref: 3e07b3b88b3984f28067a76dce5a052f0c5d3c73 | |||
There was a problem hiding this comment.
This isn't sufficient. That action still hasn't been updated to use Node20. I've posted an issue in that repo, but not sure if there are alternate paths here.
There was a problem hiding this comment.
TBH the milestone checker has been broken for a while, (it never updates once a milestone has been set for me), I think we can retire it.
There was a problem hiding this comment.
Can we investigate why it isn't working? Perhaps it needs additional types of events so that it triggers?
There was a problem hiding this comment.
Ok. I think I addressed both things
- I borrowed an implementation from vault: https://github.com/hashicorp/vault/blob/main/.github/workflows/milestone-checker.yml
- Triggers have been updated to include
milestonedanddemilestoned. We needed to update the version ofactionlintto pass a linter error -- it would previously complain that those trigger types didn't exist (https://github.com/rhysd/actionlint/releases/tag/v1.6.27) - Vault's implementation does not require a third party action, so we don't have to worry about the node version they are using anymore
|
@calcaide Just to double-check... that seems like a separate effort? I was only looking at node versions used in various github actions, whereas Cameron's work looks to be updating the application itself? |
@moduli I deleted my messare right away, this is my bad, for some reason I though this PR was affecting |
| @@ -27,7 +27,7 @@ jobs: | |||
| with: | |||
| repository: "grafana/grafana-github-actions" | |||
| path: ./actions | |||
| ref: be89ad434792280ebaa4d982ac72ba548b6f7095 | |||
| ref: 3e07b3b88b3984f28067a76dce5a052f0c5d3c73 | |||
There was a problem hiding this comment.
TBH the milestone checker has been broken for a while, (it never updates once a milestone has been set for me), I think we can retire it.
There was a problem hiding this comment.
Note to self: If we keep this workflow, we should update the node reference node-version: '16.x'
moduli
force-pushed
the
moduli-actions-node20
branch
from
e42db58
to
d2f1fd7
Compare
moduli
force-pushed
the
moduli-actions-node20
branch
from
d2f1fd7
to
5e86e3e
Compare
moduli
added
pr/no-milestone
moduli
force-pushed
the
moduli-actions-node20
branch
from
5e86e3e
to
5e9ef2a
Compare
* chore: Update to use Node20 version of Actions * CR: Add additional triggers to milestone checker * CR: Remove use of third-party action (cherry picked from commit 6eded67)
This PR updates some GitHub Actions to use a Node20 version of the Action in order to avoid deprecation warnings.