Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form_field_jq.hide(...).after is not a function #3029

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sukhoi1
Copy link

@sukhoi1 sukhoi1 commented Oct 15, 2018

jQuery "3.3.1" throws TypeError: this.form_field_jq.hide(...).after is not a function
the issue is fixed by splitting the lines.

Summary

Provide a general description of the code changes in your pull request.

Please double-check that:

  • All changes were made in CoffeeScript files, not JavaScript files.
  • You used Grunt to build the JavaScript files and tested them locally.
  • You've updated both the jQuery and Prototype versions.
  • You haven't manually updated the version number in package.json.
  • If necessary, you've updated the documentation.

See the Pull Requests section of our Contributing Guidelines for more details.

References

If your pull request is in reference to one or more open GitHub issues, please mention them here to keep the conversations linked together.

jQuery "3.3.1" throws TypeError: this.form_field_jq.hide(...).after is not a function
the issue is fixed by splitting the lines.
@stof
Copy link
Collaborator

stof commented Oct 16, 2018

So .hide() is not fluent anymore in jQuery 3.3.1 ? that's quite bad

@stof
Copy link
Collaborator

stof commented Oct 24, 2018

then the error needs more debugging, as this change should be unnecessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants