This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Unroll loops and data within toFunction() #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be functionality equivalent to before, and the unit tests remain green. The resultant function should be much more friendly to the JITter, as it contains object accesses at the top, several pure math executions (which the JITter could theoretically parallelize), and an object create upon return. A greater-than 10x speedup was observed with the new method.
|
I'm curious what this looks like, as source, before and after. Do you have the performance numbers, and the project they ran on? Very interesting stuff! |
|
Would you consider closing this here, and reopening at: https://github.com/harthur-org/brain.js/pulls? If so, we could add you as a collaborator. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be functionality equivalent to before, and the unit tests remain green.
The resultant function should be much more friendly to the JITter, as it contains object accesses at the top, several pure math executions (which the JITter could theoretically parallelize), and an object create upon return.
A greater-than 10x speedup was observed with the new method.