New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rtmp server failing to connect when auth is configured #131
Conversation
cc @harlanc |
@radiohertz Thank you for your contributions. The fix for BUG 1 is good, although it's a bit unusual to see a case where the app name includes query parameters. As for BUG 2, I need to confirm whether the query parameters are empty or if the entire 'stream_name_with_query' field is empty? |
I encountered the bug when i was pushing the stream using OBS on Linux. maybe OBS is doing something funny, but if im correct OBS still uses ffmpeg under the hood so im not really sure. @harlanc |
You'd better provide the captured RTMP network packets to do some analysis @radiohertz |
Here's a screenshot, as you can see it's an empty string. The URL i configured in OBS is You can download the capture here https://files.evsky.art/rtmpcap.pcapng |
I use ffmpeg to push the stream to xiu server, using the following address: rtmp://127.0.0.1:1935/live/x0?token=test123, and the captures: Abnormal packet capture records from @radiohertz : |
BUG 1: the app name contains the whole query param for whatever reason, this patch removes it. BUG 2: somehow the query parameters passed to on_connect function are empty even tho they exist, i just use the `connect_properties` url to get the required info instead.
2b85514
to
dd36b29
Compare
dd36b29
to
7147f23
Compare
@harlanc updated the patch and the changelog. I'd appreciate it if you can do a release on crates.io. |
okay, will do it on the weekend.. |
ping @harlanc |
Done @radiohertz |
Fix 1: the app name contains the whole query param for whatever reason, this patch removes it.
Fix 2: somehow the query parameters passed to on_connect function are empty even though they exist and the auth fails because it thinks there's no
token
even tho there is, i just use theconnect_properties
url to get the required info instead.