Implement URL Management Feature in Universal Migration Tool #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The client side fetch requests seem to be mapping to a fallback action and returning the jsp xml instead of expected json, even after updating the method and name attributes. I Plan on continue working on a solution, after getting some rest and coming back with a fresh set of eyes! :)
…s using a space instead of a comma, and then trimming the whitespace on either side of each url to avoid errors in url parsing. TODO: add urlencoding for safer handling down the line.
|
@tomusiaka , Thank you for Switching that branch over! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement URL Management Feature in Universal Migration Tool
This pull request introduces the functionality to allow users to either enter a URL or select from available saved URLs on the initial screen of the Universal Migration Tool. The React-based component manages the saved URLs, and it interacts with the Cascade CMS URL field. To be clear this code is still in progress and does NOT introduce a complete working solution due to request mapping issues between the react component and struts application. I am continuing to work on this and will update this accordingly.
New controller endpoints for creating, listing, updating, and deleting saved URLs have been added to
ProjectPropertiesAction. The persistence of the saved URLs is handled by a server-side in-memory data structure called urls which is an ArrayListChanges
Implemented a new React component for URL management under
./src/components/UrlManagementComponent. This component allows users to add, edit, delete, and select from previously saved URLs.Updated
ProjectProperties.jspto include the new React component as well as a select option that is populated dynamically from the React form upon saving an entered url.Added new controller endpoints in
ProjectPropertiesActionfor creating, listing, updating, and deleting saved URLs.Introduced a new server-side static data structure in
ProjectPropertiesActionfor persisting the saved URLs.Updated
struts.xmlto include the new endpoints.Please review the code and provide feedback. I am open to making any necessary changes.
CC: @tomusiaka, @rgriffith, @bradical
How to view changes
You can view the changes in this PR by checking out the branch in your local environment. Follow the steps below:
git checkout wgeorge1990-reactPlease let me know if you encounter any issues or have any questions.