Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] add album.py #665

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

[v3] add album.py #665

wants to merge 3 commits into from

Conversation

neon-ninja
Copy link
Contributor

@neon-ninja neon-ninja commented Nov 14, 2016

A simple plugin that makes it easier to get the album for a hangout

@gurumadmat
Copy link
Contributor

Tried your plugin, doesn't seem to work. sent several images from mobile and desktop client.
Keep getting following response:
'Send an image first'

@gurumadmat gurumadmat self-assigned this Nov 28, 2016
@neon-ninja
Copy link
Contributor Author

neon-ninja commented Dec 2, 2016

@gurumadmat give 511b929 a try, had a look through my bot logs and saw that the desired dict might be under the key data_. Probably varies due to client, I only tested with the chrome plugin.

Copy link
Contributor

@pleasantone pleasantone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems incredibly fragile and likely to break at the slightest change in the protocol... -- album = a.embed_item.data['27639957'][0][0]

  •    album = album[0:album.index('?')]
    

@neon-ninja
Copy link
Contributor Author

@pleasantone true, but it's also the only way to do it. It only needs to work once, then the result is cached forever in memory.json.

@neon-ninja
Copy link
Contributor Author

neon-ninja commented Mar 10, 2017

pleasantone called it, upgrading to v3.0 breaks this plugin. Format is now: embed_item.plus_photo.thumbnail.url

@endofline
Copy link
Member

i like to request this pr to be closed and reissued to v3 branch (with title prefixed with [v3]), as committing this to staging - being v2 - will break stuff bigly ;P

@neon-ninja neon-ninja changed the base branch from staging to v3.0 March 11, 2017 20:13
@neon-ninja neon-ninja changed the title add album.py [v3] add album.py Mar 11, 2017
@neon-ninja
Copy link
Contributor Author

@endofline no need to recreate the PR, base branch/title can be edited

@endofline
Copy link
Member

In the interest of time and focus, I will defer any review, testing and merge of this PR until after a v3 migration. Feel free to add to it though, or publish more comprehensive documentation as markup inside the pr body.

@Terrance Terrance changed the base branch from v3.0 to staging December 7, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants