-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] add album.py #665
base: staging
Are you sure you want to change the base?
[v3] add album.py #665
Conversation
Tried your plugin, doesn't seem to work. sent several images from mobile and desktop client. |
@gurumadmat give 511b929 a try, had a look through my bot logs and saw that the desired dict might be under the key data_. Probably varies due to client, I only tested with the chrome plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems incredibly fragile and likely to break at the slightest change in the protocol... -- album = a.embed_item.data['27639957'][0][0]
-
album = album[0:album.index('?')]
@pleasantone true, but it's also the only way to do it. It only needs to work once, then the result is cached forever in memory.json. |
pleasantone called it, upgrading to v3.0 breaks this plugin. Format is now: embed_item.plus_photo.thumbnail.url |
i like to request this pr to be closed and reissued to v3 branch (with title prefixed with |
@endofline no need to recreate the PR, base branch/title can be edited |
In the interest of time and focus, I will defer any review, testing and merge of this PR until after a v3 migration. Feel free to add to it though, or publish more comprehensive documentation as markup inside the pr body. |
A simple plugin that makes it easier to get the album for a hangout