Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add algolia search to documentation #10877

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

adrianspdev
Copy link
Contributor

Context

This PR includes new documentation search box with algolia

How has this been tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. https://github.com/handsontable/dev-handsontable/issues/1780

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

  • Update the documentation to use Algolia for search.
  • Search bar and results interface are visually integrated with the existing documentation website design.

[skip changelog]

Copy link

github-actions bot commented Mar 27, 2024

Launch the local version of documentation by running:

npm run docs:review 046fb5c89d74aa4a8a5052aa7c7ef12f51018160

Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrianspdev I deployed the changes to the staging, but it seems not working. There are plenty of errors coming into the console when I type something. Also, the styling appears to be broken. Could you check that?
image

@budnix budnix self-requested a review March 27, 2024 13:11
budnix
budnix previously approved these changes Mar 27, 2024
@adrianspdev adrianspdev self-assigned this Mar 28, 2024
magierg
magierg previously approved these changes Mar 28, 2024
@adrianspdev adrianspdev dismissed stale reviews from magierg and budnix via 3af0905 March 29, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants