New version of concurrent-ruby (1.2.3) broke the build #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've tested your project with an updated dependency and the build failed.
This version is either within the version range you specified or you haven't specified a version/range. To be able to test your project with the new version, we've taken the liberty of pinning the version for this branch and pull request.
Unfortunately, we encountered failing tests after pinning. This means that this new version is not compatible with your project and the test failure will potentially also happen on fresh installs.
If you have correctly specified a semantic versioning version range, you should probably also file an issue with the upstream project as they might have released an update that's breaking SemVer rules, which is not cool. (But then again, not all projects explicitly follow SemVer)
We've left the pull request open for you to investigate this issue. Please don't merge it as is, because, again, we've pinned the version of concurrent-ruby for this test run.
What changed?
✳️ concurrent-ruby (~> 1.0 → 1.2.3) · Repo · Changelog
Release Notes
1.2.3
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 25 commits:
1.2.3Add `TimerTask.new(interval_type:)` option to configure interval calculationdocs: update promises grammar (#1026)docs: fix typo in throttle docs (#1024)Add Ruby 3.3 in CIRemove AtomicReferenceMapBackend and CheapLockableFix some typosFix spurious return in Promises#wait_until_resolvedFix compile error on FreeBSD 14Drop dependency on mutex_mExpose the number of threads that are actively executing tasks with `ThreadPoolExecutor#active_count`. (#1002)Update the list of maintainersAllow TimerTask to be initialized with a specified ExecutorUse executor from arg in then_on/rescue_on/chain_on for PromisesAllow TimerSet to safely handle an executor raising `RejectedExecutionError` (#999)Fix sporadic failures testing with JRuby (#1012)Fix DaemonThreadFactory - reuse single Java thread factoryFix doc typo: yeild → yieldFix broken CI due to rake-compiler error on Ruby < 2.6Fix TimerTask example output (#1003)Fix TimerTask docs to not refer to `#execute` as "blocking" (#996)Fix TimerTask `:execution_interval` docsUpdate comment about ::Array on CRuby, it's not fully thread-safeUpdate comment about ::Hash on CRuby, it's not fully thread-safeCheck the first Concurrent::Map default_proc argument is a Concurrent::Map in more testsDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands