WIP:build: update target platform with eclipse 4.24 #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update is required because the product doesn't validate in Mac with M1 chip “eclipse”: https://download.eclipse.org/eclipse/updates/4.24/ “release”: https://download.eclipse.org/releases/2022-06
kapil-agnihotri
changed the title
stempler
reviewed
Dec 8, 2022
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <?pde version="3.5"?> | |||
|
|
|||
| <product name="halestudio Infocenter" uid="eu.esdihumboldt.hale.infocenter" id="eu.esdihumboldt.hale.doc.application.InfoCenter" application="eu.esdihumboldt.hale.doc.application.infocenterApplication" version="5.0.0.qualifier" useFeatures="false" includeLaunchers="true"> | |||
| <product name="halestudio Infocenter" uid="eu.esdihumboldt.hale.infocenter" id="eu.esdihumboldt.hale.doc.application.InfoCenter" application="eu.esdihumboldt.hale.doc.application.infocenterApplication" version="5.0.0.qualifier" useFeatures="false" includeLaunchers="true" autoIncludeRequirements="true"> | |||
There was a problem hiding this comment.
Did you test running the Infocenter product if it can serve the help successfully?
| @@ -36,6 +36,16 @@ | |||
| <repository location="https://download.eclipse.org/eclipse/updates/4.24/"/> | |||
| <unit id="org.eclipse.e4.core.tools.feature.source.feature.group" version="4.24.0.v20220420-0901"/> | |||
| <unit id="org.eclipse.sdk.ide" version="4.24.0.I20220607-0700"/> | |||
| <unit id="org.eclipse.ecf.core.feature.feature.group" version="1.6.1.v20211005-1944"/> | |||
There was a problem hiding this comment.
When we played around with the hale product run configuration on @Flaminietta 's machine she was able to remove all the ECF related plugins leaving no dependency issues related to it. So maybe something that could be removed as a dependency altogether?
Did you see where dependencies to this are present? (e.g. if it is in one of our own features)
|
This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update is required because the product doesn't validate in Mac with M1 chip
“eclipse”: https://download.eclipse.org/eclipse/updates/4.24/
“release”: https://download.eclipse.org/releases/2022-06