Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1125 cookie button #1509

Merged
merged 4 commits into from
May 15, 2024

Conversation

mlromramse
Copy link

feat: CookieNoticeButton control to show CookieBanner

small fixes in CookieNotice when selecting all cookies since the
cookie notice now can be revisited.
some prettifier justifications in App.js also.

Mikael Larsson added 2 commits May 14, 2024 08:13
small fixes in CookieNotice when selecting all cookies since the
cookie notice now can be revisited.
some prettifier justifications in App.js also.
Copy link
Member

@Hallbergs Hallbergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just add a line to CHANGELOG.md and update the old comment.

Closes #1125

Comment on lines 16 to 21
/**
* @summary Hides all visible layers
*
* @param {object} props
* @returns {object} React
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old comment, remove or update

apps/client/src/models/Cookie.js Show resolved Hide resolved
@Hallbergs Hallbergs linked an issue May 15, 2024 that may be closed by this pull request
@mlromramse mlromramse requested a review from Hallbergs May 15, 2024 06:24
@mlromramse
Copy link
Author

mlromramse commented May 15, 2024

OK, I'd love to add my change to the CHANGELOG.md but are a bit stumped over where I should put my entry.
In the 3.13.25/Added section?
Or maybe the Unreleased/Added is more appropriate?
In the top?
Is there a special format of entry to comply to?
Friendly suggestion, this part could be added to the CONTRIBUTING.md document.

@Hallbergs
Copy link
Member

Hallbergs commented May 15, 2024

OK, I'd love to add my change to the CHANGELOG.md but are a bit stumped over where I should put my entry. In the 3.13.25/Added section?

Add it to the Unreleased => Added section! (At the bottom). The content under the unreleased section will be moved to a release tag at a later stage. Try formatting the entry to follow the other entries, will make sure formatting guidelines are added to contrib!

The changelog was recently added and the contribution information hasn't been updated. Sorry!

@mlromramse
Copy link
Author

mlromramse commented May 15, 2024

OK, Should I enter the comment like this:

  • Cookie: It's now possible to revisit the cookie notice and change your preference #1125

I can enter something like this in the CONTRIBUTING.md above the point When you're done coding...

  1. Describe your change with a log entry in the CHANGELOG.md. Select the subsection below the Unreleased section based on the type of issue: Added for feature or Fixed for an alteration. Format the row like:
    - area: Short explanation of what the change resolves/adds. [#issue-number](https://github.com/hajkmap/Hajk/issues/`issue-number`)
    • area: could be a specific feature in Hajk like Sketch, Print or Cookie or an app like Admin, Backend or Client or more generic like Core, Bug, Fix.
    • issue-number: The number of your Hajk issue.

In such a case would you like to have that as a separate PR?

@Hallbergs
Copy link
Member

OK, Should I enter the comment like this:

  • Cookie: It's now possible to revisit the cookie notice and change your preference #1125

I can enter something like this in the CONTRIBUTING.md above the point When you're done coding...

  1. Describe your change with a log entry in the CHANGELOG.md. Select the subsection below the Unreleased section based on the type of issue: Added for feature or Fixed for an alteration. Format the row like:

    • area: Short explanation of what the change resolves/adds. #issue-number
    • area: could be a specific feature in Hajk like Sketch, Print or Cookie or an app like Admin, Backend or Client or more generic like Core, Bug, Fix.
    • issue-number: The number of your Hajk issue.

In such a case would you like to have that as a separate PR?

Would be awesome if you could contribute with that addition! Would like it as a separate PR in that case.

Your suggested text is great. Maybe you could add a line regarding the other sections (Removed, Security etc.). Just mention that there are guidelines regarding where the entry should be made at the bottom of the changelog file.

image

@Hallbergs Hallbergs merged commit dc9f0f3 into hajkmap:develop May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to reopen the Cookie banner during a session
2 participants