-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: clickable infobutton for groups in layerswitcher #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new feature has been added, similar to the one for layers in the layerswitcher, which allows for writing information about a specific layer; it is now available for groups. Please note that I also made some adjustments outside the scope of my affected components. Specifically, I utilized and replaced anchor tags with MUI Link for the links in the current group infobutton and also for the links in the layers infobutton
Albinahmetaj
requested review from
OlofSvahnVbg,
jesade-vbg,
jacobwod and
Hallbergs
and removed request for
jesade-vbg
April 24, 2024 07:37
…conflict Merged dev into current branch, resolved some import conflicts. Replaced mui tooltip component to our own custom tooltip component. Removed unnecessary tooltip import in LaterItem.js
Made the styling part a little more "reader friendly", I discovered that I accidentally used double inline style tags.
jesade-vbg
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tested with good results :) @OlofSvahnVbg agrees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #400
A new feature has been added, similar to the one for layers in the layerswitcher, which allows for writing information about a specific layer; it is now available for groups.
Please note that I also made some adjustments outside the scope of my affected components. Specifically, I replaced anchor tags with MUI Link for the anchor tags in my current developed group infobutton and for the anchor tags in the layers infobutton (LayerItem.js)