Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: clickable infobutton for groups in layerswitcher #1503

Merged
merged 10 commits into from
May 27, 2024

Conversation

Albinahmetaj
Copy link

@Albinahmetaj Albinahmetaj commented Apr 24, 2024

Issue: #400

A new feature has been added, similar to the one for layers in the layerswitcher, which allows for writing information about a specific layer; it is now available for groups.

Please note that I also made some adjustments outside the scope of my affected components. Specifically, I replaced anchor tags with MUI Link for the anchor tags in my current developed group infobutton and for the anchor tags in the layers infobutton (LayerItem.js)

A new feature has been added, similar to the one for layers in the layerswitcher, which allows for writing information about a specific layer; it is  now available for groups.

Please note that I also made some adjustments outside the scope of my affected components. Specifically, I utilized and replaced anchor tags with MUI Link for the links in the current group infobutton and also for the links in the layers infobutton
@Albinahmetaj Albinahmetaj requested review from OlofSvahnVbg, jesade-vbg, jacobwod and Hallbergs and removed request for jesade-vbg April 24, 2024 07:37
…conflict

Merged dev into current branch, resolved some import conflicts. Replaced mui tooltip component to our own custom tooltip component. Removed unnecessary tooltip import in LaterItem.js
@Hallbergs Hallbergs linked an issue May 15, 2024 that may be closed by this pull request
Copy link
Contributor

@jesade-vbg jesade-vbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested with good results :) @OlofSvahnVbg agrees.

@Albinahmetaj Albinahmetaj merged commit c008643 into develop May 27, 2024
@Albinahmetaj Albinahmetaj deleted the feature/400-infoButtonLsGroups branch May 27, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add info button even for groups (in LayerSwitcher)
2 participants