Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index at revision table for improving system performance 馃殌 #1856

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

yamashush
Copy link
Contributor

The SQLs to select records from the revision table is a sequential scan.
These SQLs use note id as a search key, but there is no index on the note id column.

I want to change to index scan to improve system performance 馃殌
The records in the revision table will become huge during operation, so sequential scans should be avoided.
This is especially because the following fetch processing is called frequently.

codimd/app.js

Line 277 in d157fde

models.Revision.checkAllNotesRevision(function (err, notes) {

For your reference, the organization I belong to has already changed it. (kufu#19)

@Yukaii Yukaii added this to the 2.5.4 milestone Jun 5, 2024
Signed-off-by: yamashush <38120991+yamashush@users.noreply.github.com>
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii Yukaii merged commit f00df50 into hackmdio:develop Jun 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants