Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashes to Q-Chem task documents #786

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

espottesmith
Copy link
Contributor

The (relatively) new Materials Project molecules database (here) uses Weisfeiler-Lehman graph hashes, primarily as an aspect of molecule IDs. Currently, to add tasks to our build pipeline, I have a script to incorporate the hashes into completed Q-Chem task documents. This PR instead directly incorporates the hashes in task document construction at the time of drone assimilation.

Hashes have been incorporated in the Q-Chem drone tests, and these tests pass locally.

@espottesmith
Copy link
Contributor Author

So several tasks not related to graph hashes and Q-Chem docs failed. @samblau I think one of them is related to the fragmenter. Any ideas?

@samblau
Copy link
Contributor

samblau commented Dec 6, 2023

Honestly, we should probably just deprecate / remove the fragmenter. In practice, it basically always made sense to do fragmentation in a script to customize it to a given application's species generation. I don't think the fragmentation workflow in Atomate really has any value, so if it's breaking tests, let's just get rid of it.

More broadly, I've stopped using Atomate in favor of QuAcc (and others have probably stopped using it in favor of Atomate2). I think Rishabh was working on Q-Chem stuff in Atomate2, which I think also included a new task doc schema? So it might be worth working in these changes there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants