Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Click to see more" text #889

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Tiger-The-Cat
Copy link
Contributor

@Tiger-The-Cat Tiger-The-Cat commented Sep 4, 2023

Many thanks to @sampoder for help with git

@@ -351,7 +352,36 @@ function Page({
</Link>
.
</Text>
<Grid columns={[1, 1, 1, '2.5fr 3fr']} gap={[0, 3, 4]} pt={[3, 4]}>
<Text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we used Wack Club Sans as the font?

@malted
Copy link
Member

malted commented Sep 5, 2023

Hi! Good start. Couple of things to note;

  • The font is not loading/applying in the preview deployment.
  • Look at exporting as an SVG for performance, are we using this font only once across the whole codebase? It we're not, add it to global styles and change the other occurrences to use this.
  • I would recommend adding the text below the fold.
  • This is not responsive at all.

I'm down to help you get these sorted!

@Tiger-The-Cat
Copy link
Contributor Author

Thank you @ma1ted! I've DM'ed you on Slack about a few questions that I have.

@aramshiva
Copy link
Member

any update on this?

@malted malted closed this Feb 21, 2024
@Tiger-The-Cat
Copy link
Contributor Author

Tiger-The-Cat commented Feb 21, 2024

Hey @malted, I DM'ed you a while back about this, I just replied with a ping to make my DM show up again.

@malted malted reopened this Feb 21, 2024
@malted
Copy link
Member

malted commented Feb 21, 2024

Chatting on Slack!

Copy link

vercel bot commented Feb 21, 2024

@Tiger-The-Cat is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants