OceanVoyager-smwwims #466
Merged
OceanVoyager-smwwims #466
+82
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocean Voyager from @smwwims
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is a simple piece but it's nice. Maybe you could try clipping the bottom of the boat beneath the water. My main suggestion before merging though is can you make the wave smoother? Or was it sort of blocky intentionally. I also think that |
Smoothened sin wave
Updated snapshots
|
Thank you! I smoothened the wave through the catmullRom function and changed the variables for resolution and frequency.
|
|
Nice congrats on earning your Blot. You can order it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ocean Voyager from @smwwims
I've created this artwork containing a ship and a wave made of a sinus. You can change the amplitude, starting height and the resolution of the sinus. Apart from that, you can also change the size of the ship as well as the size and the orientation of the sun.
I have a bit of a coding experince in Python and Arduino C (mainly microcontroller coding). This is my first time coding in javascript and the first time I've completely read the documentation of a library.