Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/code review #141

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat/code review #141

wants to merge 10 commits into from

Commits on Feb 4, 2024

  1. The MerkleTree contract has no comments, and it’s difficult to ascert…

    …ain the origins and meanings of various hashes and values, such as those in poseidon-zeros and blake-zeros. The tests focus solely on successful scenarios (using ‘except’) and neglect failure cases (which would use ‘expect-failure’)
    davibauer committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    38f8ca3 View commit details
    Browse the repository at this point in the history
  2. The repository’s contracts directory includes redundant or outdated f…

    …iles, like the poseidon directory
    davibauer committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    a152917 View commit details
    Browse the repository at this point in the history
  3. The repository’s contracts directory includes redundant or outdated f…

    …iles, like the poseidon directory
    davibauer committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    c30fa8d View commit details
    Browse the repository at this point in the history
  4. The project structure, as outlined in the Readme.md, seems incomplete…

    …. It fails to mention certain aspects like ‘transact’, for example
    davibauer committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    ce09a2e View commit details
    Browse the repository at this point in the history
  5. The reliance on JavaScript for generating contracts and files may not…

    … be the best approach. While it can be utilized for initial generation, the final versions should be committed to the repository
    davibauer committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    b9e4c4d View commit details
    Browse the repository at this point in the history
  6. - The contract ‘opact’ has no explanatory comments, requires a descri…

    …ption. The tests in ‘transact-tests.repl’ feature numerous commented-out lines, and there requires more test cases. Overall, there is an almost complete absence of code comments.
    
    - The usage of several formal verification annotations is noted, but nothing is checked against.
    
    - The test cases could benefit from being more comprehensive.
    davibauer committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    e4677c0 View commit details
    Browse the repository at this point in the history
  7. The Interface (gas-payer-v1) and Verifier (groth16-verifier) have no …

    …comments please add. Additionally, the test suite requires more explanatory comments
    davibauer committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    d063d7b View commit details
    Browse the repository at this point in the history
  8. The MerkleTree contract has no comments, and it’s difficult to ascert…

    …ain the origins and meanings of various hashes and values, such as those in poseidon-zeros and blake-zeros. The tests focus solely on successful scenarios (using ‘except’) and neglect failure cases (which would use ‘expect-failure’)
    davibauer committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    f4da17e View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. The contract ‘opact’ has no explanatory comments, requires a descript…

    …ion. The tests in ‘transact-tests.repl’ feature numerous commented-out lines, and there requires more test cases. Overall, there is an almost complete absence of code comments
    davibauer committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    6ff26c0 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. The contract ‘opact’ has no explanatory comments, requires a descript…

    …ion. The tests in ‘transact-tests.repl’ feature numerous commented-out lines, and there requires more test cases. Overall, there is an almost complete absence of code comments
    davibauer committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    a250395 View commit details
    Browse the repository at this point in the history