Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a predefined number icon. #54

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jhedstrom
Copy link

This adds a number icon that shows a numeral in order of the hotspots. It removes the sorting from the js script, which allows the numbers to follow the sorting of the hotspots as they are entered. This doesn't impact the display of other hotspot icon types either.

@jhedstrom
Copy link
Author

Anything left to do here? This would be great to get in :)

@marbaque
Copy link

marbaque commented Aug 18, 2022

Is it likely that this PR can be revised and accepted in the near future?

I added a future request before finding out about this pull-request. So, it is great that it is already built.

@jhedstrom
Copy link
Author

It would be great if this was merged. It's been in use on a production site for 3 years now with no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add a number/counter hotspot icon type.
2 participants