Make CKEditor resize in width #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CKEditor instance is given a fixed width intentionally in 13d1ea9, so presumably there are cases where the
autovalue for the element'swidthproperty cause problems. As a consequence, however, CKEditor instances don't resize in width when the window size is changed.On top, for very long input without spaces, the CKEditor's placeholder will not break anywhere and cause the placeholder field to overflow the parent's area.
When merged in, that will be fixed taking the aforementioned into account. The fix uses a resize listener (removed when the CKEditor instance is destroyed) to recompute and set the width for the CKEditor instance. Also, will stop the respective placeholder field from overflowing.