Add L2CAP service infrastructure #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to service BLE L2CAP connection-oriented-connections (COC). It follows the GATT service and delegate patterns. It has been tested successfully on ESP32C3 and ESP32C6 as peripherals and various iOS and MacOS devices as centrals.
Open
|
Looks great! An example would be welcome if you have time. |
|
For sure. Before this is "pull-ready", I also want to do some changes towards more defensive programming, i.e. removing all the |
|
It's been a while, but in the meantime, this code has been put through a lot of tests. Apart from one race condition (probably even be in NimBLE) when shutting down a connection while there is still ongoing traffic, everything looks pretty well. My plan is now:
Will keep you posted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #83.
This commit adds the ability to service BLE L2CAP connection-oriented-connections (COC).
It follows the GATT service and delegate patterns.
It has been tested successfully on ESP32C3 and ESP32C6 as peripherals and various iOS and MacOS devices as centrals.
NOTE: Please consider this a request-for-comments. It's probably lacking documentation and an example, but as this has been working very well for me, I thought I let it be reviewed by others.