Return a pointer to the Value object #111
Open
+3
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we get a copy, and the copy seems to clobber the data we want
Before this commit, calling
getValue()
would return a copy of the underlyingNimBLEAttValue
object. It seems like the copy doesn't necessarily copy the underlying data stored in the value. In this commit, I changed it to just return a pointer (which fixes my application), but maybe the class should know how to copy its underlying data.I'm not sure if this is the best fix (I'm not a pro C++ developer), but as I said this fixes my app.
Thanks!