Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-15989: Craft DT Example #15998

Open
wants to merge 7 commits into
base: rel-3.44.0
Choose a base branch
from
Open

GH-15989: Craft DT Example #15998

wants to merge 7 commits into from
+119 −0

Conversation

shaunyogeshwaran
Copy link
Contributor

@shaunyogeshwaran shaunyogeshwaran commented Jan 3, 2024 •
edited

fixes #15989
Crafted new examples for the DT algorithm to showcase the different parameters.

@shaunyogeshwaran shaunyogeshwaran added this to the 3.44.0.4 milestone Jan 3, 2024
@shaunyogeshwaran shaunyogeshwaran self-assigned this Jan 3, 2024
@shaunyogeshwaran shaunyogeshwaran linked an issue Jan 3, 2024 that may be closed by this pull request
DecisionTree pydocs updates #15989
Open
@hannah-tillman hannah-tillman changed the title [DOCS] Craft DT Example GH-15989: Craft DT Example Jan 5, 2024
hannah-tillman
hannah-tillman previously approved these changes Jan 12, 2024
View reviewed changes
hannah-tillman
hannah-tillman previously approved these changes Jan 18, 2024
View reviewed changes
@mn-mikke mn-mikke modified the milestones: 3.44.0.4, 3.46.0.2 Mar 4, 2024
valenad1

This comment was marked as duplicate.

Sign in to view

@valenad1 valenad1 self-requested a review March 5, 2024 13:51
valenad1
valenad1 requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One example is not working and I would use different number than default.

Otherwise, LGTM, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valenad1 valenad1 valenad1 requested changes

@hannah-tillman hannah-tillman hannah-tillman left review comments

@wendycwong wendycwong Awaiting requested review from wendycwong

Requested changes must be addressed to merge this pull request.

Assignees

@shaunyogeshwaran shaunyogeshwaran

Labels
docs
Projects
None yet
Milestone
3.46.0.2
Development

Successfully merging this pull request may close these issues.

DecisionTree pydocs updates
4 participants
@shaunyogeshwaran @valenad1 @hannah-tillman @mn-mikke