Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-15983: Craft RuleFit Examples #15984

Draft
wants to merge 10 commits into
base: rel-3.44.0
Choose a base branch
from
Draft

GH-15983: Craft RuleFit Examples #15984

wants to merge 10 commits into from

Conversation

shaunyogeshwaran
Copy link
Contributor

@shaunyogeshwaran shaunyogeshwaran commented Dec 22, 2023

#15983
Crafted new examples for the RuleFit algorithm to showcase the different parameters.

@shaunyogeshwaran shaunyogeshwaran self-assigned this Dec 22, 2023
@shaunyogeshwaran shaunyogeshwaran added this to the 3.44.0.4 milestone Dec 27, 2023
@shaunyogeshwaran shaunyogeshwaran changed the base branch from master to rel-3.44.0 January 3, 2024 07:42
@shaunyogeshwaran shaunyogeshwaran linked an issue Jan 3, 2024 that may be closed by this pull request
@hannah-tillman hannah-tillman changed the title [DOCS] Craft RuleFit Examples GH-15983: Craft RuleFit Examples Jan 5, 2024
hannah-tillman
hannah-tillman previously approved these changes Jan 12, 2024
hannah-tillman
hannah-tillman previously approved these changes Jan 18, 2024
hannah-tillman
hannah-tillman previously approved these changes Feb 29, 2024
@mn-mikke mn-mikke modified the milestones: 3.44.0.4, 3.46.0.2 Mar 4, 2024
h2o-bindings/bin/custom/python/gen_rulefit.py Outdated Show resolved Hide resolved
h2o-bindings/bin/custom/python/gen_rulefit.py Outdated Show resolved Hide resolved
h2o-bindings/bin/custom/python/gen_rulefit.py Outdated Show resolved Hide resolved
h2o-bindings/bin/custom/python/gen_rulefit.py Outdated Show resolved Hide resolved
h2o-bindings/bin/custom/python/gen_rulefit.py Outdated Show resolved Hide resolved
h2o-bindings/bin/custom/python/gen_rulefit.py Outdated Show resolved Hide resolved
h2o-bindings/bin/custom/python/gen_rulefit.py Outdated Show resolved Hide resolved
h2o-bindings/bin/custom/python/gen_rulefit.py Outdated Show resolved Hide resolved
h2o-bindings/bin/custom/python/gen_rulefit.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Wendy, I would also use different values than the default in the examples.

Copy link
Contributor

@maurever maurever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add examples only to the max_categorical_levels, algorithm, and max_num_rules parameters?

It would be nice to add examples also for:

  • min_rule_lenght
  • max_rule_length
  • model_type
  • distribution
  • rule_generation_ntrees
  • rule_importance
  • predict_rules

@wendycwong
Copy link
Contributor

Good call Veronika, I missed those rulefit specific parameters.

@shaunyogeshwaran
Copy link
Contributor Author

@maurever What would some values for rule_importance and predict_rules be? The docs don't give much info

@shaunyogeshwaran shaunyogeshwaran marked this pull request as draft March 20, 2024 06:31
@valenad1
Copy link
Collaborator

@maurever What would some values for rule_importance and predict_rules be? The docs don't give much info

rule_importance is just output. So train the model and call model.rule_importance and same for predict_rules. E.g here.

@maurever
Copy link
Contributor

Thanks, @valenad1, you are correct. It is my mistake to conclude them in the list of parameters. If I am correct, we can also add examples of how to use these functions. WDYT, @shaunyogeshwaran ?

@shaunyogeshwaran
Copy link
Contributor Author

If I am correct, we can also add examples of how to use these functions. WDYT, @shaunyogeshwaran ?

Agreed, that is something I will be able to look into. @hannah-tillman what are your thoughts on this?

@hannah-tillman
Copy link
Contributor

Agreed, that is something I will be able to look into. @hannah-tillman what are your thoughts on this?

@shaunyogeshwaran Yeah adding those examples in won't be an issue. Both of those calls are in written out in the gen_rulefit.py page so instead of adding them to the bottom of the examples list you'll just add them to their respective sections like this under :return:

:examples:
>>> example content
>>> example content
>>> etc
"""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuleFit pydoc updates
6 participants