Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-15830 - make relese independent from build number #15954

Open
wants to merge 1 commit into
base: rel-3.44.0
Choose a base branch
from
+7 −1
Open

GH-15830 - make relese independent from build number #15954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/jenkins/jenkinsfiles/Jenkinsfile-Release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@ try {
node(NODE_LABEL) {
def insideDocker = null

env.BUILD_NUMBER_DIR = currentBuild.number
if (params.VERSION.isEmpty()) {
env.BUILD_NUMBER_DIR = currentBuild.number
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to store the latest version in gradle.properties and another stage to pipeline that will increase the number if the proceeding were successful.

} else {
env.BUILD_NUMBER_DIR = params.VERSION
}

env.DATA_DIR = "/home/0xdiag"

env.GRADLE_OPTS = "-Xmx4g -XX:MaxPermSize=512m"
Expand Down Expand Up @@ -647,6 +652,7 @@ private setReleaseJobProperties(final pipelineContext) {
def jobProperties = [
disableConcurrentBuilds(),
parameters([
string(defaultValue: '', description: 'Choose version number, if empty then the build number will be used', name: 'VERSION')
booleanParam(defaultValue: !isReleaseBranch && env.BRANCH_NAME != 'master', description: "If set don't upload to PyPI and Conda, just build the packages if required; also push to ${TEST_RELEASE_BUCKET} instead of ${RELEASE_BUCKET}", name: 'TEST_RELEASE'),
booleanParam(defaultValue: isReleaseBranch && !params.TEST_RELEASE, description: 'If set, update top-level latest links and latest DOCKER tag', name: 'UPDATE_LATEST'),
booleanParam(defaultValue: true, description: 'If set, update latest links for this branch', name: 'UPDATE_LATEST_BRANCH'),
Expand Down