Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checksum] fix Frame checksum does not include Vec type. #15733

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

[Checksum] fix Frame checksum does not include Vec type. #15733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion h2o-core/src/main/java/water/fvec/Frame.java
View file
Open in desktop
Expand Up @@ -582,7 +582,6 @@ public long byteSize() {
}
_checksum *= (0xBABE + Arrays.hashCode(_names));

// TODO: include column types? Vec.checksum() should include type?
return _checksum;
}

Expand Down
4 changes: 3 additions & 1 deletion h2o-core/src/main/java/water/fvec/Vec.java
View file
Open in desktop
Expand Up @@ -949,7 +949,9 @@ public int mode() {
/** A high-quality 64-bit checksum of the Vec's content, useful for
* establishing dataset identity.
* @return Checksum of the Vec's content */
@Override protected long checksum_impl() { return rollupStats()._checksum;}
@Override protected long checksum_impl() {
return rollupStats()._checksum * (get_type() + 1);
}

public boolean isVolatile() {return _volatile;}

Expand Down