Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Guava and javax.servlet dependencies #417

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

keinhaar
Copy link
Contributor

@keinhaar keinhaar commented Dec 9, 2022

  • Removed the included 2 guava libraries and replaced them by an dependency to the bundle com.google.guava which is included in eclipse anyway.
  • replaced the javax.servlet dependency by jakarta.servlet-api, which is included since 2021-06.

- Removed the included 2 guava libraries and replaced them by an
dependency to the bundle com.google.guava which is included in eclipse
anyway.
- replaced the javax.servlet dependency by jakarta.servlet-api, which is
included since 2021-06.
@protoism
Copy link
Contributor

Hi @keinhaar,
this PR seems interesting, but I wonder how safe is using Eclipse's guava.
I wonder if we introduce a dependency between the version we need, and the version eclipse distributes.
Moreover, we're "exporting" guava. What does it mean?

About servlet APIs... the proposed fix is already in main, isn't it?

So... at the very least the PR must be re-done (best thing to do in my opinion is back merging main branch to your branch and make a manual merge)

Let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants