Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix css-builder in node 6 or higher when config.dir is undefined #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

oyola0
Copy link

@oyola0 oyola0 commented Jun 14, 2017

In node 6 or higher if path.dirname not receipt a string, throw a exception.
https://nodejs.org/dist/latest-v6.x/docs/api/path.html#path_path_dirname_path

@lriebandt
Copy link

+1

@alundiak
Copy link
Collaborator

alundiak commented Oct 6, 2017

Looks similar to #235. Will review more detailed this weekend.

Copy link

@huseyinalp-zz huseyinalp-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works as expected with gulp-requirejs.
I think you can merge.

@guybedford
Copy link
Owner

I am no longer maintaining this project, but if anyone is interested in doing that I will gladly provide access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants