Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declare main file in package.json #221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Offirmo
Copy link

@Offirmo Offirmo commented Feb 9, 2017

Hello and thanks for your awesome module !

For automation, I'd need it to declare its main file as a standard npm package (or else I have to enter it manually in some tooling)

Do you approve ?

Hello and thanks for your awesome module !
For automation, I'd need it to declare its main file as a standard npm package (or else I have to enter it manually in some tooling)
Do you approve ?
@alundiak
Copy link
Collaborator

@Offirmo I'm person, who was delegated as maintainer, so I will review your PR a bit later. I need some time to get into all stuff, and how end customer may be affected by change.

Meanwhile, could you please provide some test case, how u r using this (expecting to use) in your automation code. Also, please provide version csso, requirejs, npm use so far.

@alundiak
Copy link
Collaborator

@Offirmo btw, I discovered, that css.min.jsis not in sync with latest in master = latest in 0.1.8 release. See my comment: 3b1d868#commitcomment-20945088

@alundiak
Copy link
Collaborator

alundiak commented Feb 18, 2017

This PR is valid, and will be merged after css.js and css.min.js will be automated in regards to release version bump (I mean grunt task will be added).

@alundiak
Copy link
Collaborator

@Offirmo one more observation from code research css.min.js (which is published always to production aka npm-registry) still depends on NON-minified css-builder.js and NON-minified normalize.js. So u receive minification ~30% :)

Ideally, we should have minified all 3 files, or concatenated into one.
I will look to this later, but if u have some time and ideas, PR is very welcome.

@alundiak
Copy link
Collaborator

And one thing, which I can't accept, it's the fact, that different people/projects may need different main files. So again, @Offirmo could u please provide code example, what issue u faced with and how you resolved it (I expect u changed package.json directly in require-css, maybe some-tooling).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants