Fixes #176 by adding css-specific "optimize" option #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r pushing to require-css
Fix guybedford#176 Only perform optimization on the css content if the build's config.css.optimize option is not set to false. This is a new config option, added under require's "config" option which allows specifying module-specific configuration without polluting the global config object.
Added usage documentation to the readme for the option to enable/disable css optimization, for fixing guybedford#176
Minor update to the readme documentation for this new option to read a bit better
Removing the local test example files I created from the branch since I stupidly added them to master before creating the PR branch and don't want them in the PR.
|
Thanks for this! I'm not sure about separating the configuration though since the convention is to have Perhaps we can use another name that doesn't clash like |
Changes suggested in pull request to move config.css.optimize to optimizeRequireCSS since the rest of the require-css config doesn't use that convention.
|
Thanks @guybedford. I made the requested change. |
|
@daltonjc if your suggested code changes is ok, and still relevant, please squash commits into one, and update PR. I will review it later and merge/decline. In case of non-activity, PR will be closed, but changes might be incorporated later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the dependency on requirejs's optimizeCss option and introduced a css-specific option which can disable optimization, defaulting to true. I added this under requirejs's "config" option which allows module-specific options without polluting the "global" config thinking that's the least intrusive option going forward, but happy to change that if desired.
Let me know if anything is amiss.
UPD, by @alundiak: This is try to fix issue #176