Support custom messages (per project) #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{
"url": "https://www.theguardian.com",
"overdue": "20M",
"messages": {
"seen": "prout/seen.md",
"overdue": "prout/overdue.md"
}
}
The value for each status would be the path of a file contained in the
repository
The file content would be appended to the comment if set.
If no custom message is set, the default string 'Please check your changes!' would be appended
rtyley
approved these changes
Jun 9, 2017
There was a problem hiding this comment.
Looks great! Only thing you might want to do is add support for this new feature to the config diagnostic screen (eg on https://prout-bot.herokuapp.com/view/guardian/frontend, where you get feedback on whether Prout has successfully read all your conifg) - but I think it's ok to merge without it.
test/lib/Helpers.scala
Outdated
| .futureValue | ||
| .lastOption | ||
| .map(_.body) | ||
| .getOrElse("") |
There was a problem hiding this comment.
I often use .mkString instead of .getOrElse(""), as they're equivalent.
TBonnin
force-pushed
the
tbonnin/custom-messages
branch
3 times, most recently
from
f8f543d
to
edb901b
Compare
TBonnin
force-pushed
the
tbonnin/custom-messages
branch
from
edb901b
to
855e471
Compare
|
Here's the first comment to use this new help:
|
|
I noticed a small issue with the diagnostic page: I will push a fix when I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #52
Allow devs to specify for each checkpoint a set of files (one per status) which content would be appended to the PR comment.