actually enforce new permissions for admin and preview
#27092
Merged
+6
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2024
twrichards
force-pushed
the
editorial-permissions
branch
from
5dade89
to
d3a8bcb
Compare
twrichards
force-pushed
the
editorial-permissions-proper
branch
from
e7902de
to
b1089b9
Compare
twrichards
force-pushed
the
editorial-permissions
branch
from
d3a8bcb
to
8da0eb5
Compare
twrichards
changed the base branch from
main
to
fix-dev-build-following-pan-domain-authentication
Base automatically changed from
fix-dev-build-following-pan-domain-authentication
to
main
May 2, 2024 15:58
twrichards
force-pushed
the
editorial-permissions-proper
branch
from
b1089b9
to
f0e044b
Compare
twrichards
force-pushed
the
editorial-permissions-proper
branch
from
f0e044b
to
d63c088
Compare
twrichards
requested review from
blishen,
andrew-nowak,
bryophyta and
KarenFrankel9
ioannakok
approved these changes
May 16, 2024
… for now (rather than 403) - reverting this commit will follow in a sep. PR" This reverts commit 8da0eb5.
twrichards
force-pushed
the
editorial-permissions-proper
branch
from
d63c088
to
d4cac86
Compare
|
Seen on ADMIN-PROD (merged by @twrichards 12 minutes and 1 second ago)
|
prout-bot
added
Seen-on-ADMIN-PROD
Seen-on-FRONTS-PROD
and removed
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
labels
|
Seen on FRONTS-PROD (merged by @twrichards 12 minutes and 19 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
#27078 introduced logging when users interact with
adminandpreviewbut didn't have the necessary permission... this PR actually enforces those permissions by serving403s if the user doesn't have the permission needed.Screenshots
When the user doesn't have permission in the permissions tool (see https://github.com/guardian/permissions/pull/184):
Checklist