Use 99th percentile for target response time from Load Balancer #11409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: 0 B Total Size: 794 kB ℹ️ View Unchanged
|
Our Circuit Breaker only requires a handful of requests to go above the threshold to open, so we should really be scaling up in response to any target response time above our threshold. Co-authored-by: George B <705427+georgeblahblah@users.noreply.github.com>
mxdvl
force-pushed
the
mxdvl/elb-target-response-time
branch
from
fb9bb90
to
dc2fcec
Compare
Only consider two periods of 30s, which is 1m, before starting the scale out process. This will help close an open circuit breaker in frontend, which only takes a handful of errors or timeouts before opening. Co-authored-by: George B <705427+georgeblahblah@users.noreply.github.com>
using the p99 metrics and looking at past values, we think these are more adequately representing how we should scale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Pick the 99th percentile value from the Load Balancer metrics as the basis for scaling up.
Why?
Our Circuit Breaker only requires a handful of requests to go above the threshold to open, so we should really be scaling up in response to any target response time above our threshold of 0.4s.