Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nautilus sort list #150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akallabeth
Copy link
Contributor

@akallabeth akallabeth commented Jan 18, 2023

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 66.52% // Head: 65.99% // Decreases project coverage by -0.53% ⚠️

Coverage data is based on head (52e42dd) compared to base (12ac0c7).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   66.52%   65.99%   -0.53%     
==========================================
  Files          33       33              
  Lines        3644     3673      +29     
  Branches      772      778       +6     
==========================================
  Hits         2424     2424              
- Misses       1220     1249      +29     
Impacted Files Coverage Δ
src/nautilus/properties-list.c 0.00% <0.00%> (ø)
src/nautilus/properties.c 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tristanheaven
Copy link
Member

Thanks, this seems to be working with one problem: when you toggle HMAC on/off, the function names aren't being updated.

I think it would also be nice to sort the list when the column headers are clicked, but that could be separate change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

sort list in nautilus/caja/... properties page
2 participants