Use ipaddress to detect valid and invalid IPs #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azmeuk
force-pushed
the
issue-164-ipaddress-module
branch
from
f40e668
to
38587f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164
This leads to a breaking change: well-formed but invalid IPv6 such as
[0:0:0:0:0:0:0:1:1:1:1:1:1:1:1:9999999999999]now raise aValueError. However one can argue that this is not exactly a behavior change but more a bugfix.If you think the breaking change is too harsh, I can do another PR that would raise a deprecation warning when a well-formed invalid IPv6 is encountered, to be merged and released before this PR is merged and released.
What do you think?