Actuator healthcheck #1103
Open
Actuator healthcheck #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesmst
force-pushed
the
actuator-healthcheck
branch
from
337738f
to
b5975ea
Compare
ST-DDT
reviewed
May 2, 2024
grpc-server-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/config/HealthType.java
Outdated
Show resolved
Hide resolved
ST-DDT
reviewed
May 8, 2024
...r-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/health/ActuatorGrpcHealth.java
Outdated
Show resolved
Hide resolved
...r-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/health/ActuatorGrpcHealth.java
Outdated
Show resolved
Hide resolved
grpc-server-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/config/HealthType.java
Outdated
Show resolved
Hide resolved
...spring-boot-starter/src/main/java/net/devh/boot/grpc/server/config/GrpcServerProperties.java
Show resolved
Hide resolved
...spring-boot-starter/src/main/java/net/devh/boot/grpc/server/config/GrpcServerProperties.java
Outdated
Show resolved
Hide resolved
.../net/devh/boot/grpc/server/autoconfigure/GrpcHealthServiceTrueActuatorConfigurationTest.java
Show resolved
Hide resolved
...ring-boot-starter/src/test/java/net/devh/boot/grpc/server/health/ActuatorGrpcHealthTest.java
Show resolved
Hide resolved
...r-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/health/ActuatorGrpcHealth.java
Outdated
Show resolved
Hide resolved
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
…pc/server/autoconfigure/GrpcHealthServiceTrueActuatorConfigurationTest.java Co-authored-by: ST-DDT <ST-DDT@gmx.de>
…pc/server/health/ActuatorGrpcHealthTest.java Co-authored-by: ST-DDT <ST-DDT@gmx.de>
charlesmst
force-pushed
the
actuator-healthcheck
branch
2 times, most recently
from
459c018
to
dc3e521
Compare
charlesmst
force-pushed
the
actuator-healthcheck
branch
from
dc3e521
to
183c22b
Compare
charlesmst
force-pushed
the
actuator-healthcheck
branch
from
fd3070e
to
259cec4
Compare
charlesmst
force-pushed
the
actuator-healthcheck
branch
from
259cec4
to
65e8a1b
Compare
|
Hi @ST-DDT, thanks for the review. I think all your comments have been addressed. Let me know if you see more improvements for this feature. About the watch method, I didn't start it yet, but I was thinking in doing it in a separate PR because I think it will involve a lot more code, or do you prefer to have everything here in this pr? |
ST-DDT
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial work for #1091.
It is only implementing the
checknow, but watch will be added later by pushing metrics every 30s as @ST-DDT suggested.I was wondering if this should be the default behavior when the actuator is present, so I added a property to enable this instead of the GRPC standard health endpoint.